Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-23100: bump go to 1.21.8 #199

Merged
merged 3 commits into from
Mar 20, 2024
Merged

ROX-23100: bump go to 1.21.8 #199

merged 3 commits into from
Mar 20, 2024

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Mar 11, 2024

@janisz janisz requested a review from RTann March 11, 2024 12:53
@janisz janisz changed the title go: bump go to 1.21.7 ROX-23100: bump go to 1.21.7 Mar 11, 2024
@janisz janisz force-pushed the go1.21.7 branch 2 times, most recently from 4e01999 to da9fc5c Compare March 12, 2024 10:17
@janisz janisz changed the base branch from main to sdk-to-cli March 12, 2024 10:17
@janisz
Copy link
Contributor Author

janisz commented Mar 12, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @janisz and the rest of your teammates on Graphite Graphite

@janisz janisz mentioned this pull request Mar 12, 2024
Merged
RTann
RTann reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 1.21.8? I believe downstream says 1.21.7, but they back-port CVE fixes

@janisz
Copy link
Contributor Author

janisz commented Mar 13, 2024 •
edited
Loading

Why not 1.21.8

Good point, we need 1.21.8 for CVE fixes but first we need to resolve build issues on 1.21

Base automatically changed from sdk-to-cli to main March 15, 2024 12:25
@RTann RTann mentioned this pull request Mar 15, 2024
Closed
janisz
janisz commented Mar 18, 2024
View reviewed changes
images/collector.Dockerfile Outdated Show resolved Hide resolved
@janisz janisz requested a review from RTann March 18, 2024 14:50
@RTann RTann changed the title ROX-23100: bump go to 1.21.7 ROX-23100: bump go to 1.21.8 Mar 18, 2024
RTann
RTann reviewed Mar 18, 2024
View reviewed changes
images/scanner-test.Dockerfile Outdated Show resolved Hide resolved
images/stackrox-test.Dockerfile Outdated Show resolved Hide resolved
janisz added 2 commits March 19, 2024 12:20
@janisz
sdk → cli
5029f4f 
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz
go: bump go to 1.21.7
14d6fb0 
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz janisz requested a review from RTann March 19, 2024 11:20
@janisz
1.27.8
cb2a594 
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz janisz merged commit 23d46f2 into main Mar 20, 2024
8 checks passed
@janisz janisz deleted the go1.21.7 branch March 20, 2024 10:18
@janisz janisz mentioned this pull request Mar 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommartensen tommartensen tommartensen approved these changes

@RTann RTann Awaiting requested review from RTann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janisz @RTann @tommartensen